[PATCH] XML::Compile::SOAP on Perl 5.6.1

Toby Corkindale tjc at wintrmute.net
Fri Sep 12 03:08:59 BST 2008


On Thu, Sep 11, 2008 at 11:39:58AM +0200, Mark Overmeer wrote:
> [is this really something to get London.pm involved in?  Let's
>  continue solely on the XML::Compile mailing list after this]
> 
> * Toby Corkindale (tjc at wintrmute.net) [080911 01:38]:
> > The attached patches to Log::Report and XML::Compile::SOAP are enough
> > to get it functional on Perl 5.6, despite the normal requirements for
> > Perl 5.8.
> 
> I think both patches will make it main stream, with a little rewrite.
> What about:
> 
>   if ($] >= 5.008002)
>   {   require Encode;
>       Encode->import;
>   }
>   else
>   {   *encode = sub { $_[1] };
>   }
> 
> What do you think?  Or should it use utf8::downgrade for some subset of
> older versions?

I agree, the *encode method is much neater. I confirm it works on 5.6.1.

I'm not familiar with utf8::downgrade - are you suggesting it is available on
Perl 5.6.x? (It doesn't look like it to me)

thanks,
Toby

-- 
Turning and turning in the widening gyre/The falcon cannot hear the falconer;
Things fall apart, the centre cannot hold/Mere anarchy is loosed upon the world
(gpg --recv-key B1CCF88E)


More information about the london.pm mailing list